Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update googleapis SHA circa 2024-12-13 #14905

Merged
merged 4 commits into from
Dec 18, 2024
Merged

chore: update googleapis SHA circa 2024-12-13 #14905

merged 4 commits into from
Dec 18, 2024

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Dec 18, 2024 •
edited
Loading

This change is Reviewable

@scotthart scotthart requested review from a team as code owners December 18, 2024 18:35
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (0966d66) to head (e87559a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gle/cloud/storage/internal/storage_tracing_stub.cc 0.00% 7 Missing ⚠️
.../storage/internal/storage_round_robin_decorator.cc 0.00% 2 Missing ⚠️
google/cloud/storage/testing/mock_storage_stub.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14905      +/-   ##
==========================================
- Coverage   92.91%   92.91%   -0.01%     
==========================================
  Files        2351     2351              
  Lines      209692   209702      +10     
==========================================
  Hits       194841   194841              
- Misses      14851    14861      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotthart scotthart merged commit 7d2bb5f into googleapis:main Dec 18, 2024
73 checks passed
dbolduc
dbolduc reviewed Dec 22, 2024
View reviewed changes
external/googleapis/renovate.sh
Comment on lines +39 to +41
COMMIT=f4eff5440fd07389f820d22d2a55690c6390dc6d
COMMIT_DATE="2024-12-13"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

@dbolduc dbolduc mentioned this pull request Dec 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scotthart @dbolduc